Sam/plv8 darwin #1117
Merged
Sam/plv8 darwin #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olirice
approved these changes
Aug 13, 2024
darora
approved these changes
Aug 14, 2024
damonrand
pushed a commit
to cepro/postgres
that referenced
this pull request
Jun 15, 2025
* feat: wip fixing plv8 on darwin aarch64 * fix: build plv8 and success in enabling on darwin * fix: now builds correct and enable on aarch64-linux * fix: pg_regression updated to include plv8 extensions again * fix: print logs to stdout/stderr instead of logfile --------- Co-authored-by: Sam Rose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
We had some issues with building and enabling these extensions on
aarch64-darwinThis PR creates a build for darwin and non darwin platforms. It has been tested and verified on
x86_64-linix,aarch64-linuxandaarch64-darwinThe
nix flake check -Ltest is confirmed to pass on all 3 platforms, and thepg_regresssection of thenix flake checktest has been updated to re-introduce the 3 above extensions and those are re-added back into theprime.sqlfile.This PR closes #1094